From 3314c5e54b972fa74f1b8975c2e7c1cdbbe3a10b Mon Sep 17 00:00:00 2001
From: mohammed jasem alaajel <xrambad@glomc.net>
Date: Sat, 18 May 2024 16:46:35 +0400
Subject: [PATCH] invalidate clarifcation, remove unified jedis method from
 ProxyDataManager

---
 .../minecraft/redisbungee/api/PlayerDataManager.java        | 6 +++++-
 .../minecraft/redisbungee/api/ProxyDataManager.java         | 4 ----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/PlayerDataManager.java b/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/PlayerDataManager.java
index 94c1ed9..c102644 100644
--- a/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/PlayerDataManager.java
+++ b/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/PlayerDataManager.java
@@ -52,7 +52,7 @@ public abstract class PlayerDataManager<P, LE, DE, PS extends IPubSubMessageEven
 
     public PlayerDataManager(RedisBungeePlugin<P> plugin) {
         this.plugin = plugin;
-        this.unifiedJedis = plugin.proxyDataManager().unifiedJedis();
+        this.unifiedJedis = plugin.getSummoner().obtainResource();
         this.proxyId = plugin.proxyDataManager().proxyId();
         this.networkId = plugin.proxyDataManager().networkId();
     }
@@ -83,6 +83,8 @@ public abstract class PlayerDataManager<P, LE, DE, PS extends IPubSubMessageEven
     }
 
     protected void handleNetworkPlayerQuit(IPlayerLeftNetworkEvent event) {
+        // reason we don't set the data here because in-case of failure in redis etc,
+        // events won't reach the proxy so data would be incorrect.
         this.proxyCache.invalidate(event.getUuid());
         this.serverCache.invalidate(event.getUuid());
         this.ipCache.invalidate(event.getUuid());
@@ -93,6 +95,8 @@ public abstract class PlayerDataManager<P, LE, DE, PS extends IPubSubMessageEven
     }
 
     protected void handleNetworkPlayerJoin(IPlayerJoinedNetworkEvent event) {
+        // reason we don't set the data here because in-case of failure in redis etc,
+        // events won't reach the proxy so data would be incorrect.
         this.proxyCache.invalidate(event.getUuid());
         this.serverCache.invalidate(event.getUuid());
         this.ipCache.invalidate(event.getUuid());
diff --git a/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/ProxyDataManager.java b/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/ProxyDataManager.java
index c52cf9e..7061221 100644
--- a/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/ProxyDataManager.java
+++ b/api/src/main/java/com/imaginarycode/minecraft/redisbungee/api/ProxyDataManager.java
@@ -392,10 +392,6 @@ public abstract class ProxyDataManager implements Runnable {
         return proxyId;
     }
 
-    public UnifiedJedis unifiedJedis() {
-        return unifiedJedis;
-    }
-
     public String networkId() {
         return networkId;
     }