Add ability to store variables inside redis server database #18

New Issue

TheSkyIsCrying · 2022-05-06T01:48:13Z

TheSkyIsCrying commented

2022-05-06 01:48:13 +00:00

In sklib it was possible for redis variables to be updated for servers even if they're offline but sklib isn't updated anymore and it has a few issues. Is there a way to do it with this addon and if not can you please add an option in the config file?

Govindas commented

2022-05-06 12:23:45 +00:00

you can do it by saving variables instead of sending them until the server comes online, with your own server online detection code. I am not aware of any easy way to add this feature, as this add-on does not work based on servers, it works based on redis channels, which are always available as long as redis server is online.

Govindas commented

2022-05-06 12:27:23 +00:00

I have looked into sklib source code and it seems to be setting redis variables, not Skript variables. RediSkript only uses redis messaging functionality to transmit skript variables, it does not save them on the redis server

so sklib isn't saving variables on the server, it does connection to redis server to get a variable when requested

to implement this feature, it would require 50ms+ delay every time a single redis variable is retrieved, I do not think it's a good idea with Skript's limitations when it comes to multi threading

I have looked into sklib source code and it seems to be setting redis variables, not Skript variables. RediSkript only uses redis messaging functionality to transmit skript variables, it does not save them on the redis server so sklib isn't saving variables on the server, it does connection to redis server to get a variable when requested to implement this feature, it would require 50ms+ delay every time a single redis variable is retrieved, I do not think it's a good idea with Skript's limitations when it comes to multi threading

Govindas commented

2022-08-12 08:21:26 +00:00

If someone makes one, I will accept a pull request that adds redis variables feature as a second option of managing variables.

Govindas changed title from ~~Please make it so redis variables can be updated even for offline servers.~~ to Add ability to store variables inside redis server database

2022-08-12 08:22:11 +00:00

Govindas added the

help wanted

Suggestion

labels 2022-08-12 08:26:24 +00:00

ham1255 commented

2023-05-17 17:03:33 +00:00

if we look into SkriptDB it does make type for database we could make jedis class as type in skript?

ham1255 commented

2023-05-17 17:06:41 +00:00

sample skript code:

obtain resource from rediskript jedis pool to {_jedis_resource} # jedisPool.getResource();

set "redis key" to "value" using {_jedis_resource} # jedis.set("key", "value");


return resource {_jedis_resource} # jedis.close()

sample skript code: ``` obtain resource from rediskript jedis pool to {_jedis_resource} # jedisPool.getResource(); set "redis key" to "value" using {_jedis_resource} # jedis.set("key", "value"); return resource {_jedis_resource} # jedis.close() ```

Sign in to join this conversation.