Limework/RediSkript
2
1
Fork 1
Code Issues 2 Pull Requests Projects Releases 14 Wiki Activity

The new /reloadredis command does not seem to stop tasks correctly #1

New Issue
Closed
opened 2020-10-23 13:38:32 +00:00 by GovindasOM · 4 comments
GovindasOM commented 2020-10-23 13:38:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I find it still doing connections to the wrong IP address after reloading, while at the same time being connected to the right IP address, must find why, looks like a memory leak.

this behavior can be noticed when using NetworkInterceptor plugin

I find it still doing connections to the wrong IP address after reloading, while at the same time being connected to the right IP address, must find why, looks like a memory leak. this behavior can be noticed when using NetworkInterceptor plugin
👍 3
ham1255 commented 2020-11-27 07:05:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Lol I found the problem it's in main class you keep remaking new redis manager as I said redis manager is reusable don't make new one

Lol I found the problem it's in main class you keep remaking new redis manager as I said redis manager is reusable don't make new one
ham1255 commented 2020-11-27 07:07:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I will take care of it in 2 weeks or possibly less since I have stuff to do.

I will take care of it in 2 weeks or possibly less since I have stuff to do.
GovindasOM commented 2020-11-28 08:44:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Lol I found the problem it's in main class you keep remaking new redis manager as I said redis manager is reusable don't make new one

I think the problem is in Jedis doing some kind of ping-ponging to that IP, because redis manager in itself doesn't do any IP-based connections, thus it is not a problem of recreating redis manager, unless jedis somehow keeps connecting to wrong IP due to it?

> > > Lol I found the problem it's in main class you keep remaking new redis manager as I said redis manager is reusable don't make new one I think the problem is in Jedis doing some kind of ping-ponging to that IP, because redis manager in itself doesn't do any IP-based connections, thus it is not a problem of recreating redis manager, unless jedis somehow keeps connecting to wrong IP due to it?
GovindasOM commented 2020-12-03 11:08:37 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in next version

Fixed in next version
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Memory leak
Skript-bug
Skript bug
 Suggestion
bug
Something isn't working
 completed
Finished!
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 investigating
question
Further information is requested
 wontfix
This will not be worked on
 work in progress
No Label Memory leak bug good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Govindas ham1255
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Limework/RediSkript#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?